Skip to content

Optimize Vogel disk sampling sqrt.#32407

Merged
mrdoob merged 1 commit into
devfrom
vogel-optimization
Nov 28, 2025
Merged

Optimize Vogel disk sampling sqrt.#32407
mrdoob merged 1 commit into
devfrom
vogel-optimization

Conversation

@mrdoob

@mrdoob mrdoob commented Nov 28, 2025

Copy link
Copy Markdown
Owner

Related issue: #32303 #32381

Description

Combine two sqrt operations into one using the identity sqrt(a)/sqrt(b) = sqrt(a/b).

@mrdoob mrdoob added this to the r182 milestone Nov 28, 2025
@github-actions

Copy link
Copy Markdown

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 350.27
83.05
350.26
83.06
-4 B
+1 B
WebGPU 613.66
170.42
613.66
170.42
-4 B
+0 B
WebGPU Nodes 612.26
170.14
612.26
170.14
-4 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 482.26
117.84
482.25
117.84
-4 B
+1 B
WebGPU 684.8
186.19
684.79
186.19
-4 B
-7 B
WebGPU Nodes 634.64
173.38
634.63
173.37
-4 B
-6 B

@mrdoob mrdoob merged commit 712d2ca into dev Nov 28, 2025
10 checks passed
@mrdoob mrdoob deleted the vogel-optimization branch November 28, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant