Skip to content

WebGLRenderer: Fix PCFSoftShadowMap check.#32593

Merged
Mugen87 merged 1 commit into
mrdoob:devfrom
Mugen87:dev6
Dec 20, 2025
Merged

WebGLRenderer: Fix PCFSoftShadowMap check.#32593
Mugen87 merged 1 commit into
mrdoob:devfrom
Mugen87:dev6

Conversation

@Mugen87

@Mugen87 Mugen87 commented Dec 20, 2025

Copy link
Copy Markdown
Collaborator

Fixed #32591.

Description

I was wondering why using PCFSoftShadowMap in r182 produces no warning so I checked and realized there is a bug in WebGLShadowMap. The current shadow map type is checked on the wrong object reference.

@Mugen87 Mugen87 added this to the r183 milestone Dec 20, 2025
@github-actions

Copy link
Copy Markdown

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 355.33
84.47
355.34
84.47
+6 B
-3 B
WebGPU 617.29
171.26
617.29
171.26
+0 B
+0 B
WebGPU Nodes 615.89
171.01
615.89
171.01
+0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 487.5
119.34
487.5
119.33
+6 B
-4 B
WebGPU 688.74
187.04
688.74
187.04
+0 B
+0 B
WebGPU Nodes 638.58
174.23
638.58
174.23
+0 B
+0 B

@Mugen87 Mugen87 merged commit 5c4f7ef into mrdoob:dev Dec 20, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PCFSoftShadowMap shadows become extremely pixelated in r0.182.0 (regression from r0.181.0)

1 participant