Skip to content

WebGPURenderer: Unify uniformGroup bindings across shader stages#32602

Merged
sunag merged 1 commit into
mrdoob:devfrom
sunag:dev-bindings-group
Dec 22, 2025
Merged

WebGPURenderer: Unify uniformGroup bindings across shader stages#32602
sunag merged 1 commit into
mrdoob:devfrom
sunag:dev-bindings-group

Conversation

@sunag

@sunag sunag commented Dec 22, 2025

Copy link
Copy Markdown
Collaborator

Related issue: #32534

Description

Fixes duplicate binding declarations for uniformGroups when the same group is used in both vertex and fragment shaders. Previously, each shader stage would increment the binding index independently, causing mismatched binding indices when shared.

No changes were needed for GLSLNodeBuilder.

@sunag sunag added this to the r183 milestone Dec 22, 2025
@github-actions

Copy link
Copy Markdown

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 355.34
84.47
355.34
84.47
+0 B
+0 B
WebGPU 618.69
171.84
618.86
171.89
+174 B
+49 B
WebGPU Nodes 617.29
171.6
617.47
171.65
+174 B
+49 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 487.5
119.33
487.5
119.33
+0 B
+0 B
WebGPU 690.95
187.49
691.12
187.54
+174 B
+46 B
WebGPU Nodes 640.79
174.72
640.96
174.77
+174 B
+47 B

@sunag sunag marked this pull request as ready for review December 22, 2025 20:40
@sunag sunag merged commit a2ba6f2 into mrdoob:dev Dec 22, 2025
10 checks passed
@sunag sunag deleted the dev-bindings-group branch December 22, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant