Skip to content

ViewportTextureNode: Change update type to RENDER.#32664

Merged
sunag merged 1 commit into
mrdoob:devfrom
Mugen87:dev4
Jan 3, 2026
Merged

ViewportTextureNode: Change update type to RENDER.#32664
sunag merged 1 commit into
mrdoob:devfrom
Mugen87:dev4

Conversation

@Mugen87

@Mugen87 Mugen87 commented Jan 3, 2026

Copy link
Copy Markdown
Collaborator

Fixed #32642.

Description

As suggested in #32642 (comment), the PR changes the update type of ViewportTextureNode from FRAME to RENDER. This ensures viewport textures reflect the current state of the bound framebuffer when a render call happens which is not true when using FRAME.

@github-actions

github-actions Bot commented Jan 3, 2026

Copy link
Copy Markdown

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 355.36
84.47
355.36
84.47
+0 B
+0 B
WebGPU 621.33
172.52
621.34
172.52
+1 B
+1 B
WebGPU Nodes 619.94
172.27
619.94
172.27
+1 B
+1 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 487.23
119.23
487.23
119.23
+0 B
+0 B
WebGPU 692.28
187.78
692.28
187.78
+0 B
+2 B
WebGPU Nodes 642.08
175
642.08
175
+0 B
+1 B

@sunag sunag added this to the r183 milestone Jan 3, 2026
@sunag sunag merged commit 617ebf5 into mrdoob:dev Jan 3, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ViewportDepthTextureNode buffer caching breaks depth when using multiple targets.

2 participants