Skip to content

Line2NodeMaterial: Rename useColor property to vertexColors#32670

Merged
sunag merged 1 commit into
mrdoob:devfrom
sunag:dev-line2
Jan 5, 2026
Merged

Line2NodeMaterial: Rename useColor property to vertexColors#32670
sunag merged 1 commit into
mrdoob:devfrom
sunag:dev-line2

Conversation

@sunag

@sunag sunag commented Jan 5, 2026

Copy link
Copy Markdown
Collaborator

Fixes #32668

Description

It appears that there are duplicate names and the property is not following the naming convention adopted in the other classes.

@github-actions

github-actions Bot commented Jan 5, 2026

Copy link
Copy Markdown

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 355.36
84.47
355.36
84.47
+0 B
+0 B
WebGPU 621.49
172.57
621.5
172.57
+8 B
+1 B
WebGPU Nodes 620.1
172.32
620.11
172.33
+8 B
+1 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 487.23
119.23
487.23
119.23
+0 B
+0 B
WebGPU 692.41
187.81
692.41
187.81
+0 B
+0 B
WebGPU Nodes 642.21
175.03
642.21
175.03
+0 B
+0 B

@sunag sunag marked this pull request as ready for review January 5, 2026 15:37
@sunag sunag merged commit cc8b010 into mrdoob:dev Jan 5, 2026
10 checks passed
@sunag sunag deleted the dev-line2 branch January 5, 2026 15:42
@sunag sunag added this to the r183 milestone Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Line2NodeMaterial changed vertexColor api

2 participants