Skip to content

TSL: Fix positionView sub-build#32691

Merged
Mugen87 merged 2 commits into
mrdoob:devfrom
sunag:dev-fix-positionView-sub-build
Jan 9, 2026
Merged

TSL: Fix positionView sub-build#32691
Mugen87 merged 2 commits into
mrdoob:devfrom
sunag:dev-fix-positionView-sub-build

Conversation

@sunag

@sunag sunag commented Jan 9, 2026

Copy link
Copy Markdown
Collaborator

Fixes #32686

Description

This corrects the Clip Space implementation when using .vertexNode and reusing the positionView in the fragment stage.

@github-actions

github-actions Bot commented Jan 9, 2026

Copy link
Copy Markdown

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 355.36
84.47
355.36
84.47
+0 B
+0 B
WebGPU 621.54
172.59
621.57
172.6
+31 B
+10 B
WebGPU Nodes 620.15
172.35
620.18
172.36
+31 B
+11 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 487.31
119.25
487.31
119.25
+0 B
+0 B
WebGPU 692.53
187.85
692.57
187.86
+31 B
+9 B
WebGPU Nodes 642.34
175.07
642.37
175.08
+31 B
+10 B

@sunag sunag added this to the r183 milestone Jan 9, 2026
@sunag sunag marked this pull request as ready for review January 9, 2026 03:43

@Mugen87 Mugen87 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the changes with the reproduction test case and I can confirm the PR fixes the issue 🎉 .

@Mugen87 Mugen87 merged commit 19c76f8 into mrdoob:dev Jan 9, 2026
10 checks passed
@sunag sunag deleted the dev-fix-positionView-sub-build branch January 11, 2026 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression: logarithmicDepthBuffer issues in v181, not present in v180 -- "cut" sprites

2 participants