NodeMaterial: Remove shadowPositionNode fallback to reduce CPU load.#32699
Merged
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Collaborator
Collaborator
Author
|
I'm not sure. I did not see a CPU lload reduction when removing the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Related issue: #32675
Description
When investigating #32675, I have found out the root cause for the performance regression in
r176was #30962. I couldn't explain why #30962 increases the CPU load until I remember there were issues withObject.defineProperty(). I've simply removed the call fromNodeMaterialand the CPU load reduced noticeably (from 46% to 34 % measured with Chrome Task Manager).The example from #32675 (comment) is a bit of a edge case because it creates many individual materials (10000) but something similar can also happen in real-world scenarios with many individual render items.
I did not add real getter/setter as a replacement since that would include
shadowPositionNodeintogetMaterialCacheKey(). Given the deprecated status, I think it's okay to bump the property now and get less CPU load in exchange.