Skip to content

SkinningNode: Fix tangent transformation.#32718

Merged
sunag merged 1 commit into
mrdoob:devfrom
Mugen87:dev5
Jan 11, 2026
Merged

SkinningNode: Fix tangent transformation.#32718
sunag merged 1 commit into
mrdoob:devfrom
Mugen87:dev5

Conversation

@Mugen87

@Mugen87 Mugen87 commented Jan 11, 2026

Copy link
Copy Markdown
Collaborator

Fixed #32707.

Description

SkinningNode previously assigned the skinned normal to tangentLocal which looks not correct to me. According to what we do in WebGLRenderer, we must transform the tangent with the same skin matrix like the normal.

objectTangent = vec4( skinMatrix * vec4( objectTangent, 0.0 ) ).xyz;

The PR is correcting this bit in SkinningNode.

@Mugen87 Mugen87 added this to the r183 milestone Jan 11, 2026
@github-actions

Copy link
Copy Markdown

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 355.41
84.51
355.41
84.51
+0 B
+0 B
WebGPU 620.99
172.41
621.09
172.47
+103 B
+54 B
WebGPU Nodes 619.59
172.17
619.69
172.23
+103 B
+55 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 487.36
119.29
487.36
119.29
+0 B
+0 B
WebGPU 691.77
187.74
691.88
187.8
+103 B
+57 B
WebGPU Nodes 641.58
174.9
641.68
174.96
+103 B
+58 B

@sunag sunag merged commit ff2d509 into mrdoob:dev Jan 11, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WebGPURenderer: Flickering issue with glTF asset using tangent attribute.

2 participants