Skip to content

RenderObject: Update bundle reference at correct point.#32901

Merged
Mugen87 merged 1 commit into
mrdoob:devfrom
Mugen87:dev1
Jan 30, 2026
Merged

RenderObject: Update bundle reference at correct point.#32901
Mugen87 merged 1 commit into
mrdoob:devfrom
Mugen87:dev1

Conversation

@Mugen87

@Mugen87 Mugen87 commented Jan 30, 2026

Copy link
Copy Markdown
Collaborator

Related issue: -

Description

A minor fix in context of render bundles. The assignment of RenderObject.bundle must happen before needsRefresh() is executed to ensure the check inside NodeMaterialObserver has a valid bundle reference. This was only an issue in the first rendered frame of a render object but could lead to a wrong update.

@Mugen87 Mugen87 added this to the r183 milestone Jan 30, 2026
@github-actions

Copy link
Copy Markdown

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 359.21
85.29
359.21
85.29
+0 B
+0 B
WebGPU 623.24
173.14
623.24
173.14
+0 B
+1 B
WebGPU Nodes 621.82
172.9
621.82
172.9
+0 B
+1 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 490.47
119.49
490.47
119.49
+0 B
+0 B
WebGPU 689.9
186.31
689.9
186.31
+0 B
-1 B
WebGPU Nodes 639.28
173.72
639.28
173.72
+0 B
-1 B

@Mugen87 Mugen87 merged commit 24ece23 into mrdoob:dev Jan 30, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant