Skip to content

MaterialLoader: Simplified bool check.#33066

Merged
Mugen87 merged 1 commit into
mrdoob:devfrom
PoseidonEnergy:cleanup/json-vertexcolors-1
Feb 26, 2026
Merged

MaterialLoader: Simplified bool check.#33066
Mugen87 merged 1 commit into
mrdoob:devfrom
PoseidonEnergy:cleanup/json-vertexcolors-1

Conversation

@PoseidonEnergy

Copy link
Copy Markdown
Contributor

Simplified a boolean check in MaterialLoader.js.

@github-actions

Copy link
Copy Markdown

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 359.49
85.34
359.49
85.34
+0 B
+0 B
WebGPU 626.44
174.13
626.44
174.13
+0 B
+0 B
WebGPU Nodes 625.02
173.88
625.02
173.88
+0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 491.23
119.75
491.23
119.75
+0 B
+0 B
WebGPU 700.07
189.13
700.07
189.13
+0 B
+0 B
WebGPU Nodes 649.27
176.49
649.27
176.49
+0 B
+0 B

@Mugen87 Mugen87 changed the title Simplified bool check: json.vertexColors > 0 MaterialLoader: Simplified bool check. Feb 26, 2026
@Mugen87 Mugen87 added this to the r184 milestone Feb 26, 2026
@Mugen87 Mugen87 merged commit d8cf11e into mrdoob:dev Feb 26, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants