WebGLTextures: Prevent flipping image bitmaps.#33073
Merged
Merged
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #16144.
Description
There is an edge case in
WebGLTexturesthat currently does not work as expected. Image bitmaps might be resized when they exceed the maximum texture size of a device. In this case, they end up as an canvas image. If that happens, image bitmaps might be unexpectedly flipped because certaingl.pixelStorei()calls now have an effect which are normally ignored with image bitmaps. The PR makes sure to never setUNPACK_FLIP_Y_WEBGL,UNPACK_PREMULTIPLY_ALPHA_WEBGLandUNPACK_COLORSPACE_CONVERSION_WEBGLwhen the input isImageBitmapbecause these configuration parameters must be specified when loading/crearting the image bitmap viasetOptions(), see:https://html.spec.whatwg.org/multipage/imagebitmap-and-animations.html#the-imagebitmap-interface