WebGPURenderer: Make device capabilities handling more consistent.#33094
Merged
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: -
Description
We need to make sure
WebGPURendererbetter honors the device's capabilities. E.g. similar toWebGLRenderer, it should warn the user when a texture exceeds the maximum supported texture size and perform a resize.As a preparation for upcoming changes, this PR refactors the limits management by grouping the limit checks in dedicated modules. For that
WebGPUCapabilitiesis introduced that shares the same methods likeWebGLCapabilities. Renderer, backends and node builders should not check capabilities by themselves but use the capabilities modules to query limits.