Skip to content

TSL: Fix array texture with no .depth() defined breaks shader compilation#33096

Merged
sunag merged 1 commit into
mrdoob:devfrom
sunag:dev-fix-non-layer-defined
Mar 1, 2026
Merged

TSL: Fix array texture with no .depth() defined breaks shader compilation#33096
sunag merged 1 commit into
mrdoob:devfrom
sunag:dev-fix-non-layer-defined

Conversation

@sunag

@sunag sunag commented Mar 1, 2026

Copy link
Copy Markdown
Collaborator

Fixes #33092

Description

Use the first index of the texture 2d array if it has not been defined, avoiding the crash.

@sunag sunag added this to the r184 milestone Mar 1, 2026
@sunag sunag marked this pull request as ready for review March 1, 2026 00:02
@github-actions

github-actions Bot commented Mar 1, 2026

Copy link
Copy Markdown

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 359.57
85.37
359.57
85.37
+0 B
+0 B
WebGPU 626.97
174.23
627.02
174.26
+50 B
+24 B
WebGPU Nodes 625.55
173.98
625.6
174.01
+50 B
+24 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 491.31
119.78
491.31
119.78
+0 B
+0 B
WebGPU 700.59
189.23
700.64
189.26
+50 B
+28 B
WebGPU Nodes 649.8
176.59
649.85
176.62
+50 B
+25 B

@sunag sunag merged commit ffb3ef5 into mrdoob:dev Mar 1, 2026
10 checks passed
@sunag sunag deleted the dev-fix-non-layer-defined branch March 1, 2026 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TSL: Adding array texture as include breaks shader compilation

1 participant