TSL: Improves compilation performance by 3.0x #33120
Merged
Merged
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
This was referenced Mar 7, 2026
|
You deserve another round of applause 👏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #31691
Description
Use
webgpu_loader_materialxwhere it previously took on average~1,550msto compile all the materials in the scene on my i9 PC; currently, that same time is around~515ms.The main reason for the performance improvement was the caching of
getNodeType(), where I achieved about a~2.7ximprovement. The rest were some other minor refinements. This should be more noticeable in code that involves many operations.After some later revisions I introduced
generateNodeType()into the class; it seems that the name describes well what happens, whereas the previousgetNodeTypeis oriented toward requests where there is a cache layer.The tests were performed by summing all builds directly in
NodeBuilder.build().