Skip to content

DataTextureLoader: Fix log regression.#33148

Merged
Mugen87 merged 1 commit into
mrdoob:devfrom
Mugen87:dev6
Mar 11, 2026
Merged

DataTextureLoader: Fix log regression.#33148
Mugen87 merged 1 commit into
mrdoob:devfrom
Mugen87:dev6

Conversation

@Mugen87

@Mugen87 Mugen87 commented Mar 11, 2026

Copy link
Copy Markdown
Collaborator

Related issue: #31790

Description

The PR fixes a small regression that has been introduced via #31790 in DataTextureLoader. When the new log utils were introduces, it was missed to import error() from utils.js, probably because the error object in the catch block has the same name.

Without this fix, you get a runtime error when the loading process of a data texture fails.

@Mugen87 Mugen87 added this to the r184 milestone Mar 11, 2026
@github-actions

Copy link
Copy Markdown

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 359.27
85.31
359.27
85.31
+0 B
+0 B
WebGPU 630.16
174.95
630.16
174.95
+0 B
+0 B
WebGPU Nodes 628.75
174.7
628.75
174.7
+0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 491.13
119.74
491.13
119.74
+0 B
+0 B
WebGPU 703.41
189.9
703.41
189.9
+0 B
+0 B
WebGPU Nodes 652.64
177.33
652.64
177.33
+0 B
+0 B

@Mugen87 Mugen87 merged commit 91aff1f into mrdoob:dev Mar 11, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant