Object3D: Correctly copy pivot.#33163
Merged
Merged
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
mrdoob
reviewed
Mar 13, 2026
| this.pivot = source.pivot.clone(); | ||
|
|
||
| } | ||
| this.pivot = source.pivot ? source.pivot.clone() : null; |
Owner
There was a problem hiding this comment.
this.pivot = source.pivot !== null ? source.pivot.clone() : null;
Mugen87
changed the title
Object3D.pivot in Object3D.copy() even if the source.pivot is nullpivot.
Clean up.
Mugen87
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Object3D.pivotdoes not get set inObject3D.copy()ifsource.pivotisnull. This PR fixes that.