Skip to content

TSL: Fix two issues in StorageTextureNode#33167

Merged
sunag merged 1 commit into
mrdoob:devfrom
PoseidonEnergy:storage-texture-node-fix-1
Mar 14, 2026
Merged

TSL: Fix two issues in StorageTextureNode#33167
sunag merged 1 commit into
mrdoob:devfrom
PoseidonEnergy:storage-texture-node-fix-1

Conversation

@PoseidonEnergy

Copy link
Copy Markdown
Contributor

Issue 1

In StorageTextureNode.generateStore(), this line:

const snippet = builder.generateTextureStore( builder, textureProperty, uvSnippet, depthSnippet, storeSnippet );

should be changed to this:

const snippet = builder.generateTextureStore( this.value, textureProperty, uvSnippet, depthSnippet, storeSnippet );

This is because the first argument to WGSLNodeBuilder.generateTextureStore() is for the texture, not the builder.

Issue 2

Because StorageTextureNode.generateStore() does not return anything/returns void, the method StorageTextureNode.generate() should return '' if this.storeNode !== null.

Therefore, this logic:

generate( builder, output ) {

	let snippet;

	if ( this.storeNode !== null ) {

		snippet = this.generateStore( builder );

	} else {

		snippet = super.generate( builder, output );

	}

	return snippet;

}

should be changed to this:

generate( builder, output ) {

	if ( this.storeNode !== null ) {

		this.generateStore( builder );
		return '';

	}

	return super.generate( builder, output );

}

@PoseidonEnergy PoseidonEnergy changed the title Fix two issues in StorageTextureNode.js. Fix two issues in StorageTextureNode Mar 13, 2026
@github-actions

Copy link
Copy Markdown

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 359.32
85.32
359.32
85.32
+0 B
+0 B
WebGPU 630.01
174.94
630.02
174.95
+4 B
+2 B
WebGPU Nodes 628.59
174.7
628.6
174.7
+4 B
+2 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 491.52
119.9
491.52
119.9
+0 B
+0 B
WebGPU 703.24
189.9
703.24
189.9
+0 B
+0 B
WebGPU Nodes 652.47
177.3
652.47
177.3
+0 B
+0 B

@PoseidonEnergy PoseidonEnergy changed the title Fix two issues in StorageTextureNode TSL: Fix two issues in StorageTextureNode Mar 13, 2026
@sunag sunag added this to the r184 milestone Mar 14, 2026
@sunag sunag merged commit adfb24b into mrdoob:dev Mar 14, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants