Renderers: Cache pixel storage parameters.#33227
Merged
Merged
Conversation
Mugen87
changed the title
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Mugen87
commented
Mar 23, 2026
| const glayer = xr.getBinding().getSubImage( guiLayer, frame ); | ||
| renderer.state.bindTexture( gl.TEXTURE_2D, glayer.colorTexture ); | ||
| gl.pixelStorei( gl.UNPACK_FLIP_Y_WEBGL, true ); | ||
| renderer.state.pixelStorei( gl.UNPACK_FLIP_Y_WEBGL, true ); |
Collaborator
Author
There was a problem hiding this comment.
Since users might access gl.pixelStorei() as well, I'm going to put this change into the migration guide so users switch to state.pixelStorei().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #33223.
Description
I've realized today setting pixel storage modes in WebGL 2 is actually a global setting that affects all subsequent texture operations. Because of that, we can cache it in
WebGLState. This is now in done inWebGLRendererand the WebGL 2 backend ofWebGPURenderer.The PR also introduces
state.getParameter()for requesting cached parameters. If nothing is cached, it request the parameter value viagl.getParameter()instead.As mentioned in #33223,
getParameter()can indeed introduce performance issue. It seems depending on the WebGL implementation and the requested parameter,getParameter()can lead to a flush (which essentially means WebGL waits until all queue commands are finished by the GPU before returning the parameter value) so we should access the cache first whenever possible.