Skip to content

WGSLNodeBuilder: Fix varying indexes#33229

Merged
sunag merged 1 commit into
mrdoob:devfrom
sunag:dev-varying-indexes
Mar 23, 2026
Merged

WGSLNodeBuilder: Fix varying indexes#33229
sunag merged 1 commit into
mrdoob:devfrom
sunag:dev-varying-indexes

Conversation

@sunag

@sunag sunag commented Mar 23, 2026

Copy link
Copy Markdown
Collaborator

Fixes #33222

Description

This fixes the indices of the varyings since the optimization system may not find a varying interpolation necessary and replace it with regular variables.

@sunag sunag added this to the r184 milestone Mar 23, 2026
@github-actions

Copy link
Copy Markdown

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 360.82
85.68
360.82
85.68
+0 B
+0 B
WebGPU 632.75
175.53
632.76
175.53
+12 B
-4 B
WebGPU Nodes 630.87
175.24
630.88
175.24
+12 B
-5 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 493.02
120.25
493.02
120.25
+0 B
+0 B
WebGPU 705.18
190.51
705.19
190.5
+12 B
-4 B
WebGPU Nodes 654.4
177.79
654.41
177.78
+12 B
-5 B

@sunag sunag marked this pull request as ready for review March 23, 2026 21:57
@sunag sunag merged commit 207740d into mrdoob:dev Mar 23, 2026
10 checks passed
@sunag sunag deleted the dev-varying-indexes branch March 23, 2026 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WebGPU: Compiled code skips varying location assignment

1 participant