WebGPURenderer: Refactor env map rotation.#33232
Merged
Merged
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #33077
Description
Refactors the env map rotation logic in
MaterialPropertiesandScenePropertiesby using the cleaner matrix approach from #33077.@WestLangley The code looks a bit different compared to
WebGLRenderersince the flip is implemented inCubeTextureNode. Because of the way how the code is organized with nodes , I've sticked to the current approach and just fixed the order how transformation is applied (first rotation, then flip). That was definitely wrong inWebGPURenderer.webgpu_materials_envmapsrenders aswebgl_materials_envmapsand even the user provided test case in #33077 (comment) renders correctly inWebGPURenderer.