ObjectLoader: Fix log regression.#33240
Merged
Mugen87 merged 2 commits intoMar 25, 2026
Merged
Conversation
Mugen87
reviewed
Mar 25, 2026
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Mugen87
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a critical variable shadowing bug inside
ObjectLoader.jsthat causes the application to crash instead of gracefully handling malformed JSON.Inside
ObjectLoader.load(), whenJSON.parsefails, the error is caught by acatch ( error )block. However, the block then attempts to callerror( ... )using the imported logger utility. Because the caught exception variable shadows the imported function, this triggers aTypeError: error is not a function, crashing the execution entirely.Changes:
errortoe.e.messageto the logger so the actual syntax error is properly surfaced to the developer.ObjectLoader.tests.jsto ensure malformed JSON is caught and logged without crashing.All unit tests pass locally.