Skip to content

UniformUtils: Fix deep-copy with array of uniforms.#33384

Merged
Mugen87 merged 1 commit into
mrdoob:devfrom
Mugen87:dev5
Apr 14, 2026
Merged

UniformUtils: Fix deep-copy with array of uniforms.#33384
Mugen87 merged 1 commit into
mrdoob:devfrom
Mugen87:dev5

Conversation

@Mugen87

@Mugen87 Mugen87 commented Apr 14, 2026

Copy link
Copy Markdown
Collaborator

Fixed #16080.

Description

Makes sure the deep-copy in UniformUtils works when arrays of THREE objects (e.g. colors, vectors, matrices) as uniforms are in place.

@Mugen87 Mugen87 added this to the r184 milestone Apr 14, 2026
@github-actions

Copy link
Copy Markdown

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 361.21
85.78
361.21
85.78
+0 B
+0 B
WebGPU 637.48
177.06
637.48
177.06
+0 B
+0 B
WebGPU Nodes 635.59
176.76
635.59
176.76
+0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 493.58
120.42
493.71
120.45
+132 B
+31 B
WebGPU 709.22
191.88
709.22
191.88
+0 B
+0 B
WebGPU Nodes 658.44
179.17
658.44
179.17
+0 B
+0 B

@Mugen87 Mugen87 merged commit f9557c4 into mrdoob:dev Apr 14, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UniformUtils.cloneUniforms() does not clone arrays of objects.

1 participant