WebGLRenderer: Implement normal bias fallback.#33391
Merged
Merged
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Collaborator
Author
|
The PR actually fixes the broken self-shading of the animated horses in |
This was referenced Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #21483.
Description
Flat shading with no vertex normals can break shadows on certain devices since
shadowWorldNormalmight end up withNaNvalues.The PR fixes that by introducing a new define that detects whether a geometry has vertex normals or not and only then computes
shadowWorldNormal. Otherwise it uses the fallback value.In WebGPURenderer, we compute the normal bias in the fragment shader so the computation operates on valid normals. Hence, the test asset from #21483 works fine with
WebGPURendererfor both WebGL and WebGPU. However, doing the same inWebGLRendererrequires more refactoring and the presented approach is a sensible fallback for this edge case (not every user enabling shadows makes use ofnormalBias).