Add more tests to sdist (and maybe test_capi.cc)

[mr-c]

Thanks!

[mr-c]

For example, include lib-rt/test_capi.cc in the sdist

[ilevkivskyi]

Hm, those tests depend on googletest, we run them in mypy CI, and TBH they are a pain (e.g. they still don't work on Windows). I think it may be better to instead add a few "smoke tests", that would work reliably on all supported platforms/archs. Would something like this work for you?

[mr-c]

Smoke tests would be great! For Debian, we are happy to run more.

For building the mypy binary package, will we need to configure anything to make use of librt instead of the internal copy, or will it happen automatically?

Will mypyc-compiled Python packages automatically pick up a versioned librt dependency, or the upstream Python packages need to do that themselves? Pardon me if I'm asking a question that doesn't make sense, I'm still wrapping my head around the role of an external librt.

I guess I should try to package a snapshot of mypy, if there won't be a formal release candidate.

[ilevkivskyi]

Smoke tests would be great! For Debian, we are happy to run more.

OK, I will add some smoke tests soon. Later we may also try to figure out how to run test_api.cc, we may need to vendor a copy of googletest for this here as well.

For building the mypy binary package, will we need to configure anything to make use of librt instead of the internal copy, or will it happen automatically?

No changes should be needed. During build mypy always uses internal/vendored copy of librt headers (we will have strict ABI compatibility rules for librt so this is fine). And then at runtime we use Python capsule import to use actual librt code, as explained in https://docs.python.org/3/extending/extending.html#using-capsules. So librt is just a runtime dependency for mypy. We specify librt as a build dependency in pyproject.toml only for the purpose of running tests for freshly built mypy.

Will mypyc-compiled Python packages automatically pick up a versioned librt dependency, or the upstream Python packages need to do that themselves? Pardon me if I'm asking a question that doesn't make sense, I'm still wrapping my head around the role of an external librt.

Projects compiled with mypyc don't need to depend on librt. In (hopefully near) future we will add fast equivalents of some of Python standard library functions/classes. For example librt.contextlib.contextmanager and/or librt.threading.Lock. If users will want to use those, they will need to specify librt as a runtime dependency (again, we use vendored librt headers to compile user code). We may provide an option later to statically link librt code when compiling with mypyc instead of using capsule import, but if/when we do this, this will be opt-in behavior.

If you are curious about some decisions on this, there is more info in mypyc/mypyc#1128

[ilevkivskyi]

@mr-c I added some smoke tests to v0.2.3. TBH adding test_capi.cc is actually not that much value, as it tests mostly some internal things. I will keep this issue open, so that maybe we will find a simple way to run test_capi.cc in the future.

[mgorny]

Could you please add them to the source distribution, though? As of 0.6.2, they're still not there.

[ilevkivskyi]

As of 0.6.2, they're still not there.

Yeah, looks like I forgot to add the smoke test to the manifest. I will do this now.

[ilevkivskyi]

I just published v0.6.3 that should include the smoke tests in sdist wheel.

[mgorny]

Thanks! Confirmed that it works.