docs: Fix rich subject parameter casting in example#1974
Merged
Conversation
`id` needs to be a string according to the definitions. Otherwise it'll generate an "Object for placeholder file is invalid, value 0 for key id is not a string" Signed-off-by: Josh <josh.t.richards@gmail.com>
Activity
|
|||||||||||||||||||||||||||||||||||||
| Project |
Activity
|
| Branch Review |
docs-readme-cast
|
| Run status |
|
| Run duration | 03m 40s |
| Commit |
|
| Committer | Josh |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
2
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
8
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
cypress/e2e/sidebar.cy.ts • 2 failed tests • Run E2E
| Test | Artifacts | |
|---|---|---|
| Check activity listing in the sidebar > Has rename activity |
Test Replay
Screenshots
|
|
| Check activity listing in the sidebar > Has comment activity |
Test Replay
Screenshots
|
|
artonge
approved these changes
Apr 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
idneeds to be a string according to the definitions. Otherwise it'll generate an "Object for placeholder file is invalid, value 0 for key id is not a string"Came up while looking into:
#1967
nextcloud/server#51427
Refs:
nextcloud/server#47662
Perhaps we should also add some language about troubleshooting and isolating these problems, given the recent adjustments in the logging. The placeholders/etc are now logged (nextcloud/server#51442), but it's still a PITA to figure out which app's provider is causing it.