skip e2e encrypted files with empty filename in metadata#5448
Merged
skip e2e encrypted files with empty filename in metadata#5448
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5448 +/- ##
==========================================
- Coverage 57.97% 57.83% -0.15%
==========================================
Files 141 141
Lines 18143 18146 +3
==========================================
- Hits 10518 10494 -24
- Misses 7625 7652 +27
|
allexzander
approved these changes
Feb 17, 2023
mgallien
force-pushed
the
bugfix/ignoreInvalidE2EMetadata
branch
from
0afc593 to
2e9952e
Compare
claucambra
approved these changes
Feb 17, 2023
we cannot decrypt a file without a name for now we will ignore them we should probably do much more for the user but I fail to see how to generate errors from e2ee module Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
mgallien
force-pushed
the
bugfix/ignoreInvalidE2EMetadata
branch
from
2e9952e to
a8a5dfe
Compare
|
AppImage file: nextcloud-PR-5448-a8a5dfe6c607b9a7eecc5802d8841bdf6f1d9d27-x86_64.AppImage |
|
Kudos, SonarCloud Quality Gate passed! |
Collaborator
Author
|
/backport to stable-3.7 |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we cannot decrypt a file without a name
for now we will ignore them
we should probably do much more for the user but I fail to see how to generate errors from e2ee module