feat(push): Add option to send a self-test#2109
Merged
nickvergessen merged 1 commit intomasterfrom Dec 2, 2024
Merged
Conversation
nickvergessen
force-pushed
the
feat/1206/self-test-push
branch
2 times, most recently
from
428e2a2 to
cbb28ea
Compare
nickvergessen
force-pushed
the
feat/1206/self-test-push
branch
from
cbb28ea to
43b1ca4
Compare
nickvergessen
force-pushed
the
feat/1206/self-test-push
branch
from
43b1ca4 to
aa7dcb0
Compare
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
feat/1206/self-test-push
branch
from
aa7dcb0 to
85fe878
Compare
Contributor
|
Should we rate limit that endpoint? |
miaulalala
reviewed
Dec 2, 2024
Contributor
miaulalala
left a comment
miaulalala
left a comment
There was a problem hiding this comment.
Nice! But I agree with @SystemKeeper
Member
Author
|
Had discussed earlier already, that there are many other points we would need to ratelimit to avoid a problem here (e.g. create a public conversation and mention yourself, create a public share, set activity to push on upload and bombard yourself). And at the same time, we might want to have a temporary high frequency here anyway. I would only imagine something like 60 per hour? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1206