Create new template folder is not filled with templates

[juliusknorr]

• Creating a new templates folder should copy files from the skeleton directory or configured templatedirectory in config.php to the new folder
• This seems to be broken on master (likely also older versions)

Needs some stepping through the logic in

server/lib/private/Files/Template/TemplateManager.php

Line 252 in 9836e9b

public function initializeTemplateDirectory(?string $path = null, ?string $userId = null, $copyTemplates = true): string {

to see why it fails

[joshtrichards]

Works for me fine (in v30.0.2 least; did not check master). Tested like this:

./occ user:setting ncadmin core templateDirectory '/TemplatesX <-- bogus folder name (re-triggers Create new template folder process)

End result is a new templates folder (Templates (1) in my case since I didn't delete the real existing one) that fully matches:

www-data@83e3407f887c:~/html$ ls core/skeleton/Templates
 Brainstorming.whiteboard	     Elegant.odp	   'Impact effort.whiteboard'	'Meeting notes.md'     'Org chart.odg'	        Resume.odt		   Timesheet.ods
'Business model canvas.odg'	    'Expense report.ods'    Invoice.odt			'Mind map.whiteboard'  'Party invitation.odt'   Simple.odp		  'Venn diagram.whiteboard'
'Business model canvas.ods'	     Flowchart.odg	   'Kanban board.whiteboard'	 Mindmap.odg	       'Photo book.odt'        'Sticky notes.whiteboard'  'Yellow idea.odp'
'Business model canvas.whiteboard'   Flowchart.whiteboard   Letter.odt			'Modern company.odp'   'Product plan.md'        Syllabus.odt
'Diagram & table.ods'		    'Gotong royong.odp'    'Meeting agenda.whiteboard'	"Mother's day.odt"      Readme.md	        Timeline.whiteboard
www-data@83e3407f887c:~/html$ ls data/ncadmin/files/Templates\ \(1\)/
 Brainstorming.whiteboard	     Elegant.odp	   'Impact effort.whiteboard'	'Meeting notes.md'     'Org chart.odg'	        Resume.odt		   Timesheet.ods
'Business model canvas.odg'	    'Expense report.ods'    Invoice.odt			'Mind map.whiteboard'  'Party invitation.odt'   Simple.odp		  'Venn diagram.whiteboard'
'Business model canvas.ods'	     Flowchart.odg	   'Kanban board.whiteboard'	 Mindmap.odg	       'Photo book.odt'        'Sticky notes.whiteboard'  'Yellow idea.odp'
'Business model canvas.whiteboard'   Flowchart.whiteboard   Letter.odt			'Modern company.odp'   'Product plan.md'        Syllabus.odt
'Diagram & table.ods'		    'Gotong royong.odp'    'Meeting agenda.whiteboard'	"Mother's day.odt"      Readme.md	        Timeline.whiteboard
www-data@83e3407f887c:~/html$