Skip to content

Check if dns_get_record returns non-false#27922

Merged
kesselb merged 2 commits intomasterfrom
check-if-dnsresponse-is-false
Jul 12, 2021
Merged

Check if dns_get_record returns non-false#27922
kesselb merged 2 commits intomasterfrom
check-if-dnsresponse-is-false

Conversation

@LukasReschke
Copy link
Member

dns_get_record can return false which results in exceptions such as the ones shown in #27870.

Fixes #27870

`dns_get_record` can return false which results in exceptions such as
the ones shown in #27870.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
@LukasReschke LukasReschke added the 3. to review Waiting for reviews label Jul 12, 2021
@LukasReschke LukasReschke added this to the Nextcloud 23 milestone Jul 12, 2021
@LukasReschke LukasReschke requested a review from kesselb July 12, 2021 11:17
@LukasReschke
Copy link
Member Author

/backport to stable22

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug in DnsPinMiddleware.php, unable to resolve hostname

2 participants