feat(system-tags): show inline in files #37938
Conversation
ae58f90 to
6e26134
Compare
4489b3b to
eb6aba3
Compare
7dac009 to
e7a577e
Compare
0bf8013 to
20df001
Compare
e7a577e to
04f3170
Compare
This comment was marked as resolved.
This comment was marked as resolved.
nimishavijay
left a comment
There was a problem hiding this comment.
choosing a really long name might overlap things in certain resolutions:
Great catch, we can ellipsise for more than ~30 characters
No other comments from my side, it looks great :)
It depends how much time we actually want to spend on this. |
jancborchardt
left a comment
There was a problem hiding this comment.
Looks awesome! :) I'd say the ellipsizing is good to fix as @nimishavijay said, but the refresh can be handled later.
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
04f3170 to
cab8a07
Compare
szaimen
left a comment
There was a problem hiding this comment.
It depends how much time we actually want to spend on this.
It should be fixed with the new Files to Vue, but I'm not sure I should spend more time on this
Fine by me then
|
This looks awesome, thank you for adding this! I'm very happy that it kinda looks like my proposal. Awesome work! |
|
Thanks for the positive feedback @fechnert 🤗 |
|
@fechnert suggestions and contributions like that are always welcome! :) |
|
Awesome! They way that we use tags in our organization really would thank this new feature. We're still on 26, but planning to move to 27. Is this feature enabled by default in 27.0.5? or it will be in next releases? |
|
@gonzalo if tags are enabled, this is how they will be shown by default from 27 on. :) |
|
This is really great, but I have one question before opening a new issue: is it normal that tags don't show up in a public link view? They are displayed in the list of a logged in user. |
|
@Glandos at least in the current form and implementation, tags are considered information private to the instance. So they will indeed not show in the list, just like they didn’t show before in the link share view. |


Rebase after #37609 is merged
Light
Dark