[stable28] perf(ObjectStoreStorage): Improve (slow) move on same object bucket#48985
Merged
[stable28] perf(ObjectStoreStorage): Improve (slow) move on same object bucket#48985
Conversation
This commit fixes the issue #47856. When you upload a file into a group folder and when you use a single S3 bucket as primary storage, the final move operation hangs for a long time. In the background, Nextcloud initiates a copy-delete sequence from the bucket into the bucket, with causes a lot unnecessary overhead. Nextcloud thinks that the file must be imported to another storage and does not recognize that everything is done on the same object bucket. In that case, the import step can be completely skipped, which saves time, network bandwidth and reduces the load on the object storage. The behavior improves a lot with #46013. However, there are still some put messages that are being sent to the object storage when you use an object storage as primary storage and upload files into a group folder. Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com> Signed-off-by: Christoph Fiehe <c.fiehe@eurodata.de>
backportbot
bot
added
enhancement
3. to review
provokateurin
requested changes
Oct 29, 2024
Member
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
Wait for discussion in original PR
provokateurin
approved these changes
Oct 29, 2024
Some are still failing Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
provokateurin
approved these changes
Oct 31, 2024
Member
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
Tests are happy, then I'm happy as well 🤷♀️
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #47986