Skip to content

test(integration): Correctly cleanup logs#49273

Merged
skjnldsv merged 1 commit intomasterfrom
test/integration/cleanup-logs
Nov 14, 2024
Merged

test(integration): Correctly cleanup logs#49273
skjnldsv merged 1 commit intomasterfrom
test/integration/cleanup-logs

Conversation

@provokateurin
Copy link
Member

Summary

While running the integration tests locally I found a few problems that are fixed by this:

  • The tail is never killed, so when you run the command again you get 2x, 3x, ... the same logs
  • The previous logs are not removed, so you see the logs from previous runs as well which can be confusing
  • If the script is killed while still running (e.g. Ctrl+C) the background processes aren't killed

Checklist

Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin provokateurin added bug 3. to review Waiting for reviews labels Nov 14, 2024
@provokateurin provokateurin added this to the Nextcloud 31 milestone Nov 14, 2024
@provokateurin provokateurin requested a review from a team November 14, 2024 07:14
@skjnldsv skjnldsv merged commit e91b78d into master Nov 14, 2024
@skjnldsv skjnldsv deleted the test/integration/cleanup-logs branch November 14, 2024 09:36
@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants