Skip to content

refactor(files): Provide useFileListWidth composable#49305

Merged
susnux merged 2 commits intomasterfrom
refactor/files-filelist-width
Nov 20, 2024
Merged

refactor(files): Provide useFileListWidth composable#49305
susnux merged 2 commits intomasterfrom
refactor/files-filelist-width

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Nov 15, 2024

Summary

Replace the mixin with a composable, this is better typed and works in both: Options- and Composition API.
Also added component tests for it.

Checklist

@susnux susnux added 3. to review Waiting for reviews feature: files ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Nov 15, 2024
@susnux susnux added this to the Nextcloud 31 milestone Nov 15, 2024
@susnux susnux requested review from ShGKme and artonge November 15, 2024 11:15
@susnux susnux requested a review from skjnldsv as a code owner November 15, 2024 11:15
@susnux susnux force-pushed the refactor/files-filelist-width branch from 2c81114 to 7169dd6 Compare November 15, 2024 11:41
@susnux susnux requested a review from ShGKme November 16, 2024 21:41
@susnux susnux force-pushed the refactor/files-filelist-width branch 2 times, most recently from 9e60d54 to 5582fcb Compare November 17, 2024 00:38
@susnux susnux force-pushed the refactor/files-filelist-width branch from 5582fcb to 2216c08 Compare November 20, 2024 17:12
@susnux susnux enabled auto-merge November 20, 2024 17:12
Replace the mixin with a composable, this is better typed and works in
both: Options- and Composition API.
Also added component tests for it.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the refactor/files-filelist-width branch from 2216c08 to 91ce9c0 Compare November 20, 2024 18:10
@susnux susnux merged commit 5a8d32f into master Nov 20, 2024
@susnux susnux deleted the refactor/files-filelist-width branch November 20, 2024 18:55
@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews feature: files ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants