fix: Correct wording when attempting to remove a disabled app#49637
Merged
fix: Correct wording when attempting to remove a disabled app#49637
Conversation
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytal
added
bug
3. to review
artonge
approved these changes
Dec 4, 2024
come-nc
reviewed
Dec 4, 2024
Contributor
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
We should rename the method and the related ones, it’s highly confusing.
I’m not sure I understand how getInstalledAppsValues is working and what it’s doing.
Contributor
|
Ah, enabled can contain a list of group ids, this is what I was missing. |
come-nc
approved these changes
Dec 4, 2024
4 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the confusing wording due to the mismatch between method name vs what the method actually does
server/lib/private/App/AppManager.php
Line 391 in 0729e26
Checklist