fix: change translation logic to handle plurals better#49852
Merged
SebastianKrupinski merged 1 commit intomasterfrom Jan 7, 2025
Merged
fix: change translation logic to handle plurals better#49852SebastianKrupinski merged 1 commit intomasterfrom
SebastianKrupinski merged 1 commit intomasterfrom
Conversation
SebastianKrupinski
requested review from
st3iny and
tcitworld
as code owners
Contributor
Author
|
/backport to stable30 |
Contributor
Author
|
Code added in 30, do not backport further. |
rakekniven
approved these changes
Dec 14, 2024
ChristophWurst
approved these changes
Dec 18, 2024
ChristophWurst
added
4. to release
ChristophWurst
requested changes
Dec 18, 2024
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Needs a squash for clean git history.
Requesting as change so this isn't merged prematurely.
SebastianKrupinski
force-pushed
the
fix/issue-49756-translations
branch
from
a31501b to
e0a8d74
Compare
ChristophWurst
approved these changes
Dec 19, 2024
SebastianKrupinski
force-pushed
the
fix/issue-49756-translations
branch
from
e0a8d74 to
887c258
Compare
st3iny
requested changes
Dec 24, 2024
Member
st3iny
left a comment
st3iny
left a comment
There was a problem hiding this comment.
Still not clean. Please rebase when updating the branch instead of merging master into your work branch.
SebastianKrupinski
force-pushed
the
fix/issue-49756-translations
branch
from
26313ff to
3e2d890
Compare
st3iny
approved these changes
Dec 27, 2024
SebastianKrupinski
force-pushed
the
fix/issue-49756-translations
branch
from
3e2d890 to
b88563e
Compare
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
st3iny
force-pushed
the
fix/issue-49756-translations
branch
from
b88563e to
a912556
Compare
2 tasks
Member
|
We did it, after like 20 attempts 🎉 🎉 🎉 |
Contributor
Author
🤣 🤣 🤣 Yeah, tell me about it. Now we can have the same fun with the backport |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist