fix(previews): Make thumbnail generation a bit more robust#50009
Merged
nickvergessen merged 1 commit intomasterfrom Jan 3, 2025
Merged
fix(previews): Make thumbnail generation a bit more robust#50009nickvergessen merged 1 commit intomasterfrom
nickvergessen merged 1 commit intomasterfrom
Conversation
009097b to
ef00e96
Compare
Contributor
|
oleksandr-nc
approved these changes
Jan 2, 2025
juliusknorr
approved these changes
Jan 2, 2025
ef00e96 to
c23db81
Compare
nickvergessen
approved these changes
Jan 2, 2025
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Josh <josh.t.richards@gmail.com>
c23db81 to
37a9460
Compare
AndyScherzinger
approved these changes
Jan 2, 2025
solracsf
approved these changes
Jan 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes thumbnail generation a bit more robust for Office / MP3 / Image / Movie types.
Same thing is already being done for other types e.g. HEIC:
server/lib/private/Preview/HEIC.php
Lines 45 to 52 in c54038c
TODO
Checklist