feat(AppFramework): extend range check to optional parameters

[blizzz]

Summary

Now it also applies when a parameter is documented with a preceding ? or pending |null, but no further unionation is considered.

So previously the range check worked against parameters that were not nullable:

/**
  * @psalm-param int<1,500> $thisWasChecked
  * @psalm-param int<1,500>|null $thisWentUnderTheRadar
  * @psalm-param ?int<1,500> $thisWentUnderTheRadarAsWell
  * /

Now all cases are handled.

To keep in mind: when a parameter is passed in the query string without a value, it is considered an empty string, not a null value. To not risk breakage, we should refrain from backporting.

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[nickvergessen]

Backport?

[blizzz]

Backport?

From the description:

To keep in mind: when a parameter is passed in the query string without a value, it is considered an empty string, not a null value. To not risk breakage, we should refrain from backporting.

Do you have a different opinion on it?