feat: command to list and delete calendar subscriptions#51136
Conversation
kesselb
requested review from
SebastianKrupinski,
st3iny and
tcitworld
as code owners
kesselb
force-pushed
the
feat/noid/occ-list-delete-calendar-subscription
branch
from
5f0abd6 to
ff1fde6
Compare
| } | ||
|
|
||
| $subscriptionInfo = $this->calDavBackend->getSubscriptionByUri( | ||
| 'principals/users/' . $user, |
There was a problem hiding this comment.
I really hate, that we have to do this, but I get it at the moment there is no other way.
There was a problem hiding this comment.
What is the issue? I don't see it yet
There was a problem hiding this comment.
That we constantly have to append and remove 'principals/users/'
|
Looks good otherwise
|
|
Thanks for reviewing and testing 👍 Looks like you accidentally tested the existing command instead of my new one 😆 No worries, happens 🙈 The PR introduces Would be great if you could give that one a spin 🚀 |
(Face Palm) On it |
|
Yup still good... Looks good too
|
kesselb
force-pushed
the
feat/noid/occ-list-delete-calendar-subscription
branch
from
ff1fde6 to
85ac8d3
Compare
kesselb
requested review from
icewind1991,
provokateurin and
yemkareems
and removed request for
a team
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
force-pushed
the
feat/noid/occ-list-delete-calendar-subscription
branch
from
85ac8d3 to
c410e08
Compare
ChristophWurst
added
the
pending documentation
|
Documentation: nextcloud/documentation#12983 |
kesselb
removed
the
pending documentation
5 participants
Summary
Add occ command to list and delete calendar subscriptions
TODO
Checklist