[stable31] fix(dav): check the owner displayName scope before giving attribute#52554
Merged
[stable31] fix(dav): check the owner displayName scope before giving attribute#52554
Conversation
backportbot
bot
added
bug
3. to review
skjnldsv
force-pushed
the
backport/52535/stable31
branch
from
6e45ff8 to
d635865
Compare
skjnldsv
approved these changes
Apr 30, 2025
Member
|
/compile |
skjnldsv
force-pushed
the
backport/52535/stable31
branch
from
d635865 to
b051492
Compare
Signed-off-by: skjnldsv <skjnldsv@protonmail.com> [skip ci]
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
skjnldsv
force-pushed
the
backport/52535/stable31
branch
from
da68e47 to
ee90847
Compare
susnux
reviewed
Apr 30, 2025
| class="note-to-recipient" | ||
| type="info"> | ||
| <p v-if="user" class="note-to-recipient__heading"> | ||
| <p v-if="displayName" class="note-to-recipient__heading"> |
Contributor
There was a problem hiding this comment.
overlooked it in the master PR, but why adding a new computed instead of just:
Suggested change
| <p v-if="displayName" class="note-to-recipient__heading"> | |
| <p v-if="user.displayName" class="note-to-recipient__heading"> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #52535
Warning, This backport had conflicts that were resolved with the⚠️
oursmerge strategy and is likely incompleteTodo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.