test: Finish migrating tests/Core/ to PHPUnit 10 compatible code#52588
Merged
nickvergessen merged 1 commit intomasterfrom May 5, 2025
Merged
test: Finish migrating tests/Core/ to PHPUnit 10 compatible code#52588nickvergessen merged 1 commit intomasterfrom
nickvergessen merged 1 commit intomasterfrom
Conversation
nickvergessen
requested review from
nfebe,
skjnldsv and
sorbaugh
and removed request for
a team
nickvergessen
force-pushed
the
test/noid/more-phpunit-10
branch
3 times, most recently
from
624701c to
88bb26c
Compare
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
test/noid/more-phpunit-10
branch
from
88bb26c to
c24f5fb
Compare
provokateurin
approved these changes
May 5, 2025
come-nc
approved these changes
May 5, 2025
|
|
||
| $hookListener = $this->getMockBuilder('Dummy')->setMethods(['listener'])->getMock(); | ||
| $hookListener = $this->createMock(DummyShareManagerListener::class); | ||
| \OCP\Util::connectHook('\OC\Share', 'verifyExpirationDate', $hookListener, 'listener'); |
Contributor
There was a problem hiding this comment.
Tests should not rely on hooks 😿
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist