refactor: cleanup public code and clean psalm baseline#52846
Merged
provokateurin merged 2 commits intomasterfrom May 15, 2025
Merged
refactor: cleanup public code and clean psalm baseline#52846provokateurin merged 2 commits intomasterfrom
provokateurin merged 2 commits intomasterfrom
Conversation
susnux
requested review from
come-nc,
provokateurin and
yemkareems
and removed request for
a team
susnux
added
3. to review
susnux
force-pushed
the
refactor/ocp-deprecations
branch
from
51b5ea9 to
75e1260
Compare
Member
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
Cool, just one minor thing you might want to check if you haven't done already.
come-nc
reviewed
May 14, 2025
come-nc
reviewed
May 14, 2025
provokateurin
approved these changes
May 15, 2025
come-nc
approved these changes
May 15, 2025
susnux
force-pushed
the
refactor/ocp-deprecations
branch
from
6692219 to
30be2db
Compare
susnux
force-pushed
the
refactor/ocp-deprecations
branch
from
30be2db to
3c62048
Compare
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
refactor/ocp-deprecations
branch
from
3c62048 to
74bded7
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist