feat(files): allow to proper search in files#53662
Merged
Conversation
9511307 to
28a4e88
Compare
skjnldsv
approved these changes
Jul 1, 2025
Member
There was a problem hiding this comment.
Awesome work!
Some tiny issues which are non blocking imho, we can get this in to avoid conflicts and adjust those slight changes in follow-ups :)
- the double reset icon

- When focused, you cannot change the search scope. I'm not sure what would be best.
- When no results on current view, it looks kinda weird. Not fully related to this PR, but we could maybe improve in a follow-up

- Finally, I think the search icon makes the menu not very discoverable

28a4e88 to
068ac42
Compare
Contributor
Author
Chome based browser? I guess its the search box default styling.
Do you have any recommendation? Otherwise I will bring this up also in a design review :) |
Member
Yep ;)
I would use a cogwheel icon I think :) |
068ac42 to
f07e296
Compare
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
f07e296 to
541f550
Compare
Member
|
Congrats on the merge! |
This was referenced Jul 2, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist