fix(systemtags): Provide initial state for admin restriction setting#55177
Merged
fix(systemtags): Provide initial state for admin restriction setting#55177
Conversation
The “Restrict tag creation and editing to administrators” switch in the SystemTags admin settings was not reflecting the correct database value on page load. This happened because no initial state was being provided. Fix This change ensures the correct initial state is set by: - Injecting IAppConfig and IInitialState dependencies. - Following the same initial state provisioning pattern used by other admin settings in Nextcloud. Signed-off-by: nfebe <fenn25.fn@gmail.com>
nfebe
requested review from
a team,
ArtificialOwl,
provokateurin and
sorbaugh
and removed request for
a team
Contributor
Author
|
/backport to stable32 |
Contributor
Author
|
/backport to stable31 |
Contributor
Author
|
/backport to stable30 |
Member
|
CC FYI @maximelehericy |
come-nc
approved these changes
Sep 22, 2025
susnux
approved these changes
Sep 24, 2025
|
The backport to # Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/55177/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 18d571e3
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/55177/stable30Error: Failed to push branch backport/55177/stable30: remote: {"auth_status":"auth_error","body":"Invalid username or token. Password authentication is not supported for Git operations."} Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
This was referenced Sep 24, 2025
Member
|
/backport to stable30 |
2 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The “Restrict tag creation and editing to administrators” switch in the SystemTags admin settings was not reflecting the correct database value on page load. This happened because no initial state was being provided.
Fix
This change ensures the correct initial state is set by: