Conversation
Member
MorrisJobke
commented
Feb 13, 2018
MorrisJobke
commented
- Remove crypto and timefactory from UsersController
- Remove config from AutoCompleteController
- Remove fromMailAddress from MailSettingsController
- Was removed in Beautify test email #4379 (0a54d5a) and Add instance name to default sender #4380 (bae64e8)
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
requested review from
blizzz,
nickvergessen,
rullzer and
schiessle
ChristophWurst
approved these changes
Feb 14, 2018
| return $c->query('ServerContainer')->getWebRoot(); | ||
| }); | ||
|
|
||
| $this->registerService('fromMailAddress', function() { |
Member
Author
There was a problem hiding this comment.
It is only used by us in this one occurence ... not sure we want to provide this. (searched across all apps in the appstore)
Member
Author
There was a problem hiding this comment.
But we could also keep this ofc
Member
There was a problem hiding this comment.
Kill it for now then. Just be sure the add it to the changes for devs
Member
Author
|
@nickvergessen @rullzer Can we get this in? |
rullzer
approved these changes
Feb 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
