Return groups displayname in provisioning api#8865
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8865 +/- ##
============================================
+ Coverage 51.88% 51.89% +0.01%
- Complexity 25283 25287 +4
============================================
Files 1604 1604
Lines 94918 94929 +11
Branches 1388 1388
============================================
+ Hits 49245 49262 +17
+ Misses 45673 45667 -6
|
|
This breaks a public API - could you link it in the ticket that collects all of these changes? cc @rullzer @nickvergessen Is it fine to do the change? |
|
@MorrisJobke which ticket? Also, wz definitely needs to support such data since last nickvergessen's pr. We should have implemented it at the time I think! :) |
Sure, but it still breaks existing code, because
no.
The ticket about breaking changes: #7827 |
|
Indeed! So how should we do that? Do you want me to create another entry point? :) |
|
Mmm I would vote for a 'displayName' parameter or so. Defaulting to false. So we don't break the API. But when true returning this. |
|
Parameter sounds good to me |
nickvergessen
left a comment
There was a problem hiding this comment.
Please dont break the api, but add a parameter which when set also returns the display name.
@rullzer finally agreed we should change this. |
|
CI said no: 😉 |
e32d9b4 to
3f890b4
Compare
|
Okay, I added a new endpoint like the users list. It fit our url design better and avoid the breaking of our current api, sorry for the change @nickvergessen @rullzer! :) |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
3f890b4 to
5f38cfb
Compare
|
Would be nice to also cover all those new endpoints with integration tests btw ;) |
|
@rullzer I'll do it in a future pr while replacing the proper Exceptions with the non-deprecated ones :) Also, I restarted, but failure is unrelated, test before rebase was successful on those who timed out on the curren tone :) |
Following #8255
Needed by #8824