Merged
Conversation
* Password Update Notification Added an IF ELSE statement to ensure that feedback is provided to the user on successfully updating a user password in settings. * Password Update Success Message Updated the password update success message
|
@MorrisJobke, thanks for your PR! By analyzing the annotation information on this pull request, we identified @rullzer, @ringmaster and @PVince81 to be potential reviewers |
Member
|
please backport |
Member
|
👍 |
1 similar comment
Member
|
👍 |
Member
Author
|
@Mar1u5 @nickvergessen Could one of you take care of the backport? That would be nice 👍 |
Member
|
I'll do that 👍 |
Member
|
Conflicts in |
This was referenced Aug 22, 2016
GitHubUser4234
pushed a commit
to GitHubUser4234/server
that referenced
this pull request
Aug 30, 2016
…word-change Add feedback for password change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @nickvergessen @LukasReschke @rullzer
@karlitschek I would like to backport this otherwise it looks like the password can be changed even if the password is not allowed policy wise.