Update master php testing versions#6844
Merged
vitormattos merged 2 commits intomasterfrom Jan 28, 2022
Merged
Conversation
Signed-off-by: Joas Schilling <coding@schilljs.com>
33 tasks
skjnldsv
approved these changes
Jan 28, 2022
nickvergessen
commented
Jan 28, 2022
.github/workflows/phpunit.yml
Outdated
| fail-fast: false | ||
| matrix: | ||
| php-versions: ['7.3', '7.4'] | ||
| php-versions: ['7.4', '8.0'] |
Member
Author
There was a problem hiding this comment.
@vitormattos we need to update phpunit it seems?
Contributor
There was a problem hiding this comment.
Is hardcoded on row 58, we can bump to 9.5.13
Signed-off-by: Vitor Mattos <vitor@php.rio>
Contributor
|
@nickvergessen we will do backport to stable branches? |
nickvergessen
commented
Jan 28, 2022
| fail-fast: false | ||
| matrix: | ||
| php-versions: ['7.4', '8.0'] | ||
| php-versions: ['7.3', '7.4'] |
Member
Author
There was a problem hiding this comment.
you reverted the actual sense of the PR :D
Member
Author
No, they still support 7.3? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joas Schilling coding@schilljs.com