fix(ImageView): Use mouseenter instead of mouseover#8064
Merged
Conversation
Member
Author
|
/backport to stable32 |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
The mouseover event event bubbles, which means that hovering child elements also triggers it. This can lead to bad performance. Thus it's better to use mouseenter. See https://developer.mozilla.org/en-US/docs/Web/API/Element/mouseenter_event#usage_notes Signed-off-by: Jonas <jonas@freesources.org>
mejo-
force-pushed
the
fix/imageview_mouseenter
branch
from
a1de4d0 to
4478c2d
Compare
silverkszlo
approved these changes
Dec 15, 2025
Collaborator
silverkszlo
left a comment
silverkszlo
left a comment
There was a problem hiding this comment.
Tested it in Firefox and Chromium and it seems to work nicely! :)
Member
Author
|
/backport to stable31 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mouseover event event bubbles, which means that hovering child elements also triggers it. This can lead to bad performance. Thus it's better to use mouseenter.
See https://developer.mozilla.org/en-US/docs/Web/API/Element/mouseenter_event#usage_notes
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)