Add a .file entry to .s files#7
Merged
r-devulap merged 1 commit intonumpy:mainfrom Jul 30, 2025
bmwiedemann:random
Merged
Conversation
for reproducible builds. Without this patch, building _multiarray_umath.cpython-312-x86_64-linux-gnu.so with debuginfo contained the random temporary ccXXXXXX.o filenames used by gcc for assembler output. There are details in https://bugzilla.opensuse.org/show_bug.cgi?id=1245203#c9
r-devulap
approved these changes
Jul 30, 2025
Member
r-devulap
left a comment
r-devulap
left a comment
There was a problem hiding this comment.
LGTM. Thanks for reporting and fixing it! @bmwiedemann
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
.fileentry to.sfiles for reproducible builds.Without this patch, building
_multiarray_umath.cpython-312-x86_64-linux-gnu.sowith debuginfo contained the random temporary ccXXXXXX.o filenames used by gcc for assembler output.There are details in
https://bugzilla.opensuse.org/show_bug.cgi?id=1245203#c9
btw: the lines were added with