Wire managed MITM CA trust into child env#22668

winston-openai · 2026-05-14T18:40:25Z

Stack

Parent PR: Use named MITM permissions config #18240 uses named MITM permissions config.
This PR wires managed MITM CA trust into spawned child processes.

Why

When Codex terminates HTTPS for limited mode or MITM hooks, child HTTPS clients need to trust Codex's managed MITM CA. Exporting proxy URLs alone is not enough, but blindly replacing user CA settings would be wrong: it can break custom enterprise/test roots, leak unreadable CA files into generated bundles, or make the child env disagree with its sandbox policy.

Summary

Build immutable managed CA bundles under $CODEX_HOME/proxy that include native roots, the managed MITM CA, and only inherited or command-scoped CA bundles the child is allowed to read.
Export curated CA env vars alongside managed proxy env vars while preserving user CA override semantics, including nested Codex SSL_CERT_FILE precedence.
Thread generated CA bundle paths into child sandbox readable roots, including debug sandbox execution, so the exported env vars work inside sandboxed commands.
Remove only Codex-generated MITM CA bundle env when a child intentionally drops managed proxying for escalation or no-proxy retry.
Document the managed CA bundle behavior and cover env injection, per-child bundle generation, sandbox readable roots, and no-proxy cleanup in tests.

Validation

Ran just test -p codex-network-proxy.
Ran just test -p codex-protocol.
Ran just fix -p codex-network-proxy -p codex-protocol.
Tried focused codex-core validation, but the crate currently fails to compile in core/tests/suite/guardian_review.rs because an existing Op::UserInput initializer is missing additional_context.

github-actions · 2026-05-14T18:40:36Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 13e783f35b

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

winston-openai · 2026-05-26T20:55:00Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e910c8c788

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

winston-openai · 2026-05-27T11:16:22Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bb82054dd0

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

winston-openai · 2026-05-29T18:15:03Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 971cbc3d86

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

winston-openai · 2026-05-29T18:42:34Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0cd665434c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

winston-openai · 2026-05-29T19:12:49Z

@codex review

chatgpt-codex-connector

💡 Codex Review

codex/codex-rs/network-proxy/src/certs.rs

Lines 457 to 459 in 987c62e

    
           let dir = File::open(parent).with_context(|| format!("failed to open {}", parent.display()))?; 
        
           dir.sync_all() 
        
               .with_context(|| format!("failed to fsync {}", parent.display()))?;

Avoid fsyncing directories on Windows

On Windows, File::open(parent) for a directory typically fails with access denied, so every new write_atomic_create_new call returns an error after creating/linking the file. When MITM is first enabled on Windows this can leave ca.key written but report failure before ca.pem is created, after which subsequent startups hit the “both managed MITM CA files must exist” path and MITM remains unusable until the user manually cleans $CODEX_HOME/proxy. Gate the directory fsync to platforms that support opening directories, or make it best-effort.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

winston-openai · 2026-05-29T19:29:15Z

[codex] Addressed the Windows directory-fsync feedback in 6c939f9: file contents are still fsynced, but the parent-directory fsync is gated off on Windows where opening directories via File::open is not reliable.

winston-openai · 2026-05-29T19:29:19Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6c939f9b0c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

winston-openai · 2026-05-29T20:08:05Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7a21873b67

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

winston-openai · 2026-05-29T20:47:51Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b2ba6db5f2

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

viyatb-oai

Reviewed current head. No remaining blocking findings under the agreed scope for command-scoped custom CA overrides.

evawong-oai and others added 7 commits May 15, 2026 05:20

Add MITM hook config model

4334b19

Clarify full mode MITM hook behavior

cdefa6f

Keep MITM profile config internal

af01135

Wire MITM hooks into runtime enforcement

2c9ccbe

Use named MITM permissions config

b4a1e10

Preserve MITM hook order

60c5973

Wire managed MITM CA trust into child env

a410150

winston-openai force-pushed the codex/mitm-feature-gate-landing branch from 7a319d2 to 60c5973 Compare May 15, 2026 12:33

winston-openai force-pushed the dev/winston/mitm-ca-trust branch from bf01363 to a410150 Compare May 15, 2026 12:33

Fix MITM CA trust build failures

9fa22ca

evawong-oai force-pushed the codex/mitm-feature-gate-landing branch 2 times, most recently from 09024fe to b4ceb64 Compare May 20, 2026 23:42

Base automatically changed from codex/mitm-feature-gate-landing to main May 21, 2026 00:10

winston-openai added 2 commits May 26, 2026 11:12

Merge main into dev/winston/mitm-ca-trust

4dc6530

Fix app-server env import Clippy lint

13e783f

winston-openai marked this pull request as ready for review May 26, 2026 19:52

chatgpt-codex-connector Bot reviewed May 26, 2026

View reviewed changes

Comment thread codex-rs/network-proxy/src/certs.rs Outdated

Comment thread codex-rs/network-proxy/src/certs.rs Outdated

Comment thread codex-rs/network-proxy/src/proxy.rs Outdated

Comment thread codex-rs/network-proxy/src/certs.rs

winston-openai added 2 commits May 26, 2026 13:18

Clean up MITM CA env wiring

672045c

Address MITM CA trust review feedback

e910c8c

chatgpt-codex-connector Bot reviewed May 26, 2026

View reviewed changes

Comment thread codex-rs/network-proxy/src/proxy.rs Outdated

Comment thread codex-rs/network-proxy/src/certs.rs

Trust managed MITM CA in Linux sandboxes

595d035

winston-openai requested a review from a team as a code owner May 26, 2026 22:45

winston-openai added 4 commits May 26, 2026 16:30

Preserve Linux CA bundles for MITM trust

e29a8a4

Address remaining MITM CA trust feedback

f935762

Merge remote-tracking branch 'origin/main' into HEAD

4a86c1b

Simplify MITM CA trust feedback fix

bb82054

chatgpt-codex-connector Bot reviewed May 27, 2026

View reviewed changes

Fix MITM CA env cleanup

971cbc3

chatgpt-codex-connector Bot reviewed May 29, 2026

View reviewed changes

Comment thread codex-rs/network-proxy/src/certs.rs Outdated

Comment thread codex-rs/network-proxy/src/proxy.rs Outdated

Comment thread codex-rs/core/src/tools/runtimes/mod.rs Outdated

Trim MITM CA trust diff

0cd6654

chatgpt-codex-connector Bot reviewed May 29, 2026

View reviewed changes

Address MITM CA review feedback

987c62e

chatgpt-codex-connector Bot reviewed May 29, 2026

View reviewed changes

Comment thread codex-rs/network-proxy/Cargo.toml

Avoid directory fsync on Windows

6c939f9

chatgpt-codex-connector Bot reviewed May 29, 2026

View reviewed changes

Comment thread codex-rs/network-proxy/src/certs.rs Outdated

Comment thread codex-rs/network-proxy/src/proxy.rs Outdated

winston-openai added 2 commits May 29, 2026 13:06

Trim MITM CA trust plumbing

e7231c1

Merge main into dev/winston/mitm-ca-trust

7a21873

chatgpt-codex-connector Bot reviewed May 29, 2026

View reviewed changes

Comment thread codex-rs/network-proxy/src/certs.rs

Comment thread codex-rs/network-proxy/src/proxy.rs

Comment thread codex-rs/network-proxy/Cargo.toml

Expose managed MITM bundle to sandboxes

b2ba6db

chatgpt-codex-connector Bot reviewed May 29, 2026

View reviewed changes

Comment thread codex-rs/network-proxy/src/proxy.rs

Comment thread codex-rs/network-proxy/Cargo.toml

winston-openai added 3 commits May 29, 2026 17:45

Drop unused core landlock CA wiring

4978f1b

Retag MITM CA follow-up TODO

efec451

Broaden MITM CA follow-up TODO

f3f550f

viyatb-oai approved these changes May 30, 2026

View reviewed changes

pakrym-oai approved these changes Jun 1, 2026

View reviewed changes

winston-openai enabled auto-merge (squash) June 1, 2026 16:16

Merge branch 'main' into dev/winston/mitm-ca-trust

c23ee4a

winston-openai merged commit bca18cb into main Jun 1, 2026
46 of 47 checks passed

winston-openai deleted the dev/winston/mitm-ca-trust branch June 1, 2026 23:24

github-actions Bot locked and limited conversation to collaborators Jun 1, 2026

	let dir = File::open(parent).with_context(\|\| format!("failed to open {}", parent.display()))?;
	dir.sync_all()
	.with_context(\|\| format!("failed to fsync {}", parent.display()))?;

Conversation

winston-openai commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Stack

Why

Summary

Validation

Uh oh!

github-actions Bot commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

winston-openai commented May 26, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

winston-openai commented May 27, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

winston-openai commented May 29, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

winston-openai commented May 29, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

winston-openai commented May 29, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

winston-openai commented May 29, 2026

Uh oh!

winston-openai commented May 29, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

winston-openai commented May 29, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

winston-openai commented May 14, 2026 •

edited

Loading

github-actions Bot commented May 14, 2026 •

edited

Loading